Add vscode:// and replit:// to external protocol allowlist#151
Merged
sergeichestakov merged 1 commit intomainfrom Mar 11, 2024
Merged
Add vscode:// and replit:// to external protocol allowlist#151sergeichestakov merged 1 commit intomainfrom
sergeichestakov merged 1 commit intomainfrom
Conversation
WS-3018 Open in VS Code doesn't work in the desktop app
We block you from opening custom (non http(s)) URIs so the |
sergeichestakov
requested review from
a team,
Monkatraz and
szymonkaliski
and removed request for
a team
jackyzha0
approved these changes
Mar 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We want
replit://links to work in the app for obvious reasons (e.g. performing actions or opening new windows via links) and also want to supportvscode://URLs explicitly so that the new "Open in VS Code" button and relevant SSH functionality works as expected (see attached Linear task).Fixes WS-3018
What changed
Add vscode:// and replit:// to external protocol allowlist
Test plan
replit://and/orvscode://links from the app -> works