Skip to content

Add vscode:// and replit:// to external protocol allowlist #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sergeichestakov merged 1 commit into from
Mar 11, 2024
Merged

Add vscode:// and replit:// to external protocol allowlist #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/createWindow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,10 @@ function getPlatformSpecificStyling({
return {};
}

const EXTERNAL_PROTOCOLS_ALLOW_LIST = ['http', 'https', 'replit', 'vscode'].map(
(p) => `${p}:`,
);

export function createWindow(props?: WindowProps): BrowserWindow {
updateStoreWithFocusedWindowValues();
const backgroundColor = store.getLastSeenBackgroundColor();
Expand Down Expand Up @@ -206,8 +210,9 @@ export function createWindow(props?: WindowProps): BrowserWindow {
if (!isReplit || !isSupportedPage(u.pathname)) {
event.preventDefault();

// Don't open URLs with protocols other than http / https externally since they may open other apps.
if (u.protocol !== 'https:' && u.protocol !== 'http:') {
// Don't open URLs with protocols other than those we explicitly allow otherwise to prevent users
// from opening external apps and running untrusted code that could compromise their machines.
if (!EXTERNAL_PROTOCOLS_ALLOW_LIST.includes(u.protocol)) {
return;
}

Expand Down