Conversation
- `res._headers` has been deprecated and accessing it in `auditResponseSerializer` generates exception (RangeError: Maximum call stack size exceeded) - `res.getHeaders` returns an object that does not inherit from `Object`, so is unsuitable for use here - falls back to `res._headers` if public APIs (introduced in v7.7.0) do not exist - see https://nodejs.org/api/deprecations.html#deprecations_dep0066_outgoingmessage_headers_outgoingmessage_headernames - see https://nodejs.org/api/http.html#http_response_getheaders
|
Failing tests are unrelated to PR |
|
Could we hae this fix also for 4.x? |
|
The upgrade guide looks a little long, I wasn't planning on upgrading yet. Not that this is the best place to ask, but is there anything more to do to upgrade to 6.x? AH! Waiting for the change from #1473 to be published. |
|
Hey @avimar 😄 We use semantic versioning and conventional commits so it should be pretty easy to track what has changed between releases by looking at our commit history on master. https://github.com/restify/node-restify/commits/master There is a lot to unpack there when moving from 4->5, which is why the migration guide exists, but 5-6 doesn't contain many changes to the API. Most changes were backwards compatible (unless you depended on internals or undocumented behaviour) and the ones that aren't are labeled Hope this helps ❤️ |
2 participants
Supersedes #1369