Skip to content

Fix get headers 4.x#1473

Merged
retrohacker merged 5 commits into4.xfrom
fix-getHeaders-4.x
Sep 7, 2017
Merged

Fix get headers 4.x#1473
retrohacker merged 5 commits into4.xfrom
fix-getHeaders-4.x

Conversation

@DonutEspresso
Copy link
Member

Fixes #1470. Exactly the same as #1407 except for 4.x.

Happy to land this and get 4.x working for node 8. Longer term, might be worth starting a discussion for EOL for 4.x. What is our level of support moving forward?

@retrohacker
Copy link
Contributor

I'd say 4.x is minimally supported at this point. All work is going into 5.x. I think, moving forward, anyone should feel free to open PRs back-porting fixes to previous releases as they need them. I'd be happy to help those PRs land and to cut the release, but I don't think I'll be back porting fixes myself.

Copy link
Contributor

@retrohacker retrohacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@retrohacker
Copy link
Contributor

Merging as the review was done on #1407 and #1408

@osher
Copy link

osher commented Sep 12, 2017

what version is this fix part of? is it published?

@sean3z sean3z deleted the fix-getHeaders-4.x branch September 12, 2017 13:10
@retrohacker
Copy link
Contributor

This should be part of the next release for 4.x

We really need to get automated publishes working.

@avimar
Copy link
Contributor

avimar commented Nov 13, 2017

Oh, this hasn't been released yet... please push a release. Thanks!

@avimar avimar mentioned this pull request Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants