Conversation
Contributor
|
I'd say 4.x is minimally supported at this point. All work is going into 5.x. I think, moving forward, anyone should feel free to open PRs back-porting fixes to previous releases as they need them. I'd be happy to help those PRs land and to cut the release, but I don't think I'll be back porting fixes myself. |
Contributor
Closed
3 tasks
|
what version is this fix part of? is it published? |
Contributor
|
This should be part of the next release for 4.x We really need to get automated publishes working. |
Contributor
|
Oh, this hasn't been released yet... please push a release. Thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1470. Exactly the same as #1407 except for 4.x.
Happy to land this and get 4.x working for node 8. Longer term, might be worth starting a discussion for EOL for 4.x. What is our level of support moving forward?