Closed
Conversation
|
This would be much appreciated, fixes an issue with apicache as well. |
yunong
suggested changes
Jul 12, 2017
| Response.prototype.getHeaders = function getHeaders() { | ||
| return (this._headers || {}); | ||
| }; | ||
| if (typeof Response.prototype.getHeaders !== 'function') { |
Contributor
There was a problem hiding this comment.
Could you please move the JS Doc down into the if block on top of the function? Additionally If you could then add a comment before the if block about why this is necessary, that'd be great. Once we get the comments fixed we should be ready to land this. Thanks so much!
Author
There was a problem hiding this comment.
@retrohacker beat me to it. Thank you for the quick response. May we get a npm minor version bump for this?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
make prepushIssues
Closes:
Changes
In Node 7.7+ we use the
http.ServerResponse.getHeaders()instead of creating a new prototype function.