return error when calling stop without first calling start#138
Merged
brandur merged 3 commits intoriverqueue:masterfrom Dec 31, 2023
Merged
return error when calling stop without first calling start#138brandur merged 3 commits intoriverqueue:masterfrom
brandur merged 3 commits intoriverqueue:masterfrom
Conversation
brandur
reviewed
Dec 31, 2023
Contributor
brandur
left a comment
brandur
left a comment
There was a problem hiding this comment.
Good idea! Left a couple comments here, but I like it.
pmenglund
commented
Dec 31, 2023
brandur
added a commit
that referenced
this pull request
Jan 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you call
Stop()without first callingStart()you get a null pointer panic. Returning an error is much more user friendly.