Skip to content

return error when calling stop without first calling start #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandur merged 3 commits into from
Dec 31, 2023
Merged

return error when calling stop without first calling start #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04313b6
return error when calling stop without first calling start
pmenglund Dec 31, 2023
08a3df2
address code review feedback
pmenglund Dec 31, 2023
85672cf
reverse predicate
pmenglund Dec 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,6 +681,10 @@ func (c *Client[TTx]) signalStopComplete(ctx context.Context) {
// There's no need to call this method if a hard stop has already been initiated
// by cancelling the context passed to Start or by calling StopAndCancel.
func (c *Client[TTx]) Stop(ctx context.Context) error {
if c.fetchNewWorkCancel == nil {
return errors.New("client not started")
}

c.baseService.Logger.InfoContext(ctx, c.baseService.Name+": Stop started")
c.fetchNewWorkCancel()
return c.awaitStop(ctx)
Expand Down
9 changes: 9 additions & 0 deletions client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,15 @@ func Test_Client_Stop(t *testing.T) {
}
}

t.Run("not started", func(t *testing.T) {
t.Parallel()
client := newTestClient(ctx, t, newTestConfig(t, nil))

err := client.Stop(ctx)
require.Error(t, err)
require.Equal(t, "client not started", err.Error())
})

t.Run("no jobs in progress", func(t *testing.T) {
t.Parallel()
client := runNewTestClient(ctx, t, newTestConfig(t, nil))
Expand Down