fix: prevent NullPointerException in RNMBXAtmosphere.addStyles()#4171
Open
zamausa wants to merge 2 commits intornmapbox:mainfrom
Open
fix: prevent NullPointerException in RNMBXAtmosphere.addStyles()#4171zamausa wants to merge 2 commits intornmapbox:mainfrom
zamausa wants to merge 2 commits intornmapbox:mainfrom
Conversation
Replace non-null assertions (!!) on mReactStyle and mMap with safe early-return null checks to prevent crashes when addStyles() is called before these properties are initialized.
zamausa
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
zamausa
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
Contributor
|
@zamausa thanks much for the PR, any chance you can include a small reproducer component?! To demo the issue?! |
zamausa
requested a deployment
to
CI with Mapbox Tokens
GitHub Actions
Waiting
zamausa
requested a deployment
to
CI with Mapbox Tokens
GitHub Actions
Waiting
zamausa
requested a deployment
to
CI with Mapbox Tokens
GitHub Actions
Waiting
Contributor
Author
|
Thanks for the feedback! I added a small reproducer component to this PR. |
mfazekas
added a commit
that referenced
this pull request
Mar 15, 2026
Two bugs fixed in RNMBXAtmosphere: 1. NPE in addStyles() when <Atmosphere /> is used with no props — mReactStyle!! throws NullPointerException because setReactStyle() is never called before addToMap(). Replaced !! with safe null early-returns. (related to PR #4171) 2. removeFromMap() was calling removeTerrain() instead of removeAtmosphere() (copy-paste bug), causing terrain to disappear when toggling Atmosphere off while the atmosphere itself stayed. Also now nulls mAtmosphere on removal for clean state. Also adds atmosphere toggle + color cycling to TerrainSkyAtmosphere and QueryTerrainElevation examples, and updates BugReportExampleTS with the AtmosphereRaceRepro test case from PR #4171. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix crash in
RNMBXAtmosphere.addStyles()caused by non-null assertions (!!) onmReactStyleandmMap. WhenaddStyles()is called before these properties are initialized (e.g. viasetReactStyle()beforeaddToMap()), the!!operator throws aNullPointerException.Replaced with safe early-return null checks using Kotlin
?:patterns, consistent with howmAtmosphereis already guarded.Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)Component to reproduce the issue you're fixing
Any usage of the
<Atmosphere>component can trigger the crash whensetReactStyleis called before the component is added to the map.