fix(android): fix Atmosphere NPE on no-props and wrong removeFromMap#4173
Closed
fix(android): fix Atmosphere NPE on no-props and wrong removeFromMap#4173
Conversation
Two bugs fixed in RNMBXAtmosphere: 1. NPE in addStyles() when <Atmosphere /> is used with no props — mReactStyle!! throws NullPointerException because setReactStyle() is never called before addToMap(). Replaced !! with safe null early-returns. (related to PR #4171) 2. removeFromMap() was calling removeTerrain() instead of removeAtmosphere() (copy-paste bug), causing terrain to disappear when toggling Atmosphere off while the atmosphere itself stayed. Also now nulls mAtmosphere on removal for clean state. Also adds atmosphere toggle + color cycling to TerrainSkyAtmosphere and QueryTerrainElevation examples, and updates BugReportExampleTS with the AtmosphereRaceRepro test case from PR #4171. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two bugs fixed in
RNMBXAtmosphere.kton Android:addStyles()when<Atmosphere />has no props —mReactStyle!!throwsNullPointerExceptionbecausesetReactStyle()is never called (no props = no call), whileaddToMap()still callsaddStyles(). Replaced!!force-unwraps with safe null early-returns. This subsumes the fix in PR fix: prevent NullPointerException in RNMBXAtmosphere.addStyles() #4171.removeFromMap()calledremoveTerrain()instead ofremoveAtmosphere()— a copy-paste bug causing terrain to disappear when toggling<Atmosphere>off, while the atmosphere itself stayed. Also clearsmAtmosphereon removal for clean state.Also adds atmosphere toggle + color cycling buttons to
TerrainSkyAtmosphereandQueryTerrainElevationexamples to make the behavior easy to test, and updatesBugReportExampleTSwith the race repro from PR #4171.Test plan
TerrainSkyAtmosphereon Android — toggle atmosphere on/off, confirm atmosphere (not terrain) disappearsBugReportExampleTSon Android — confirm no crash on load, remount works🤖 Generated with Claude Code