PR for Nth day of the Week on Mth Occurrence#321
Open
pallavJha wants to merge 3 commits intorobfig:masterfrom
Open
PR for Nth day of the Week on Mth Occurrence#321pallavJha wants to merge 3 commits intorobfig:masterfrom
pallavJha wants to merge 3 commits intorobfig:masterfrom
Conversation
pallavJha
changed the title
Author
|
Hi @robfig, I've not updated the doc and README. I'll do it once the Code Review is complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the feature of executing a job on nth Day of the Week. Now, the DoW spec can be of the form,
N#Mwhere N is the Day of the Week,Sunday(0) to Saturday(6), and M is the occurrence number,1 to 4orLfor Last week.For example,
Mon Jun 1 01:00 2020and the cron spec is1 1 * 6 4#3then the next execution date will beMon Jun 18 01:01 2020.Mon Jun 1 01:00 2020and the cron spec is1 1 * 6 4#Lthen the next execution date will beMon Jun 25 01:01 2020.