Closed
Conversation
Author
|
Any thoughts, @robfig ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that adding deps may not be appreciated so this is an alternate to #327
It adds zero deps, with the tradeoff that there's no convenient way to perform mocked-time tests within the package. (Seems like it might be useful for things like #321 or #325 but that's not my call.)
I did leave the schedule behavior test in there, behind a build tag, so you can try it out with
go test --tags=clockif you like. I can also remove that file, but I thought it gave a good example of how to perform mocked-time tests, including the adapter needed to wire in themixer/clock.