Skip to content

fix: Update Rollup dependencies#1326

Merged
lukastaegert merged 29 commits intorollup:masterfrom
meyfa:fix/update-rollup-dependencies
Oct 20, 2022
Merged

fix: Update Rollup dependencies#1326
lukastaegert merged 29 commits intorollup:masterfrom
meyfa:fix/update-rollup-dependencies

Conversation

@meyfa
Copy link
Contributor

@meyfa meyfa commented Oct 20, 2022

Rollup Plugin Name: all of them

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other (dependency update)

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers: See PR #1321 where this was discussed.

Description

PR #1321 was reverted since the release script needs separate commits for each package.
This PR is an attempt at making that happen. I have opened it as draft, since I am on Windows and cannot test locally, so I will have to make one commit at a time and see that CI passes.

Note that the PR may not be squashed, and must instead be merged using fast-forward merge!

@meyfa
Copy link
Contributor Author

meyfa commented Oct 20, 2022

Progress tracker:

  • alias
  • auto-install
  • babel
  • beep
  • buble
  • commonjs
  • data-uri
  • dsv
  • dynamic-import-vars
  • eslint
  • graphql
  • html
  • image
  • inject
  • json
  • legacy
  • multi-entry
  • node-resolve
  • pluginutils
  • replace
  • run
  • strip
  • sucrase
  • typescript
  • url
  • virtual
  • wasm
  • yaml

@meyfa meyfa marked this pull request as ready for review October 20, 2022 14:40
@meyfa
Copy link
Contributor Author

meyfa commented Oct 20, 2022

@lukastaegert All done. As you can see, each commit is individually green. This was an enormous pain to achieve, but should enable a clean fast-forward onto the master branch. I just hope the release script works this time.

@lukastaegert
Copy link
Member

This was an enormous pain

I know, I did this a short time ago.

each commit is individually green

actually, I think it would have been ok for CI if only the very last commit had been green, that is the only one that is actually being tested during release. But of course this way it is even nicer. Will give it another go, fingers crossed. Thank you so much!

@lukastaegert lukastaegert merged commit 3b4d9ec into rollup:master Oct 20, 2022
@lukastaegert
Copy link
Member

Ok, the commits arrived individually on master, but the release script only bothered to release the last one. I think this release script does not really support PRs for multiple plugins after all... If I understand the script correctly, though, there might be a chance to trigger the release via a single PR that changes one single thing in every file. Will try to give this theory a shot.

@lukastaegert
Copy link
Member

See #1327

@shellscape
Copy link
Collaborator

@lukastaegert I'd really, really appreciate if you'd slow down a bit within the plugins repo. If it's super important, you know how to get ahold of me outside of github. All that said, this was not merged correctly for a multi-plugin commit that runs the release and publish for each plugin. All PRs should be squash merged. The PR title (and commit message) should be in the format:

fix(plugin1,plugin2,plugin3): some thing

Before merging, each PR should get at least two approvals within a reasonable amount of time. That applies to maintainers as well. With the recent flurry of activity around Rollup v3, I'd previously asked for more collaboration before forging ahead. I'd like to ask for that again.

@shellscape shellscape mentioned this pull request Oct 20, 2022
9 tasks
@shellscape
Copy link
Collaborator

I've completed the rebasing work and all plugins have been published. Thanks for your work on this, it's appreciated.

@meyfa
Copy link
Contributor Author

meyfa commented Oct 22, 2022

You're welcome, and thank you for creating the releases!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants