Skip to content

fix(repo): trigger releases#1327

Merged
lukastaegert merged 1 commit intomasterfrom
trigger-releases
Oct 20, 2022
Merged

fix(repo): trigger releases#1327
lukastaegert merged 1 commit intomasterfrom
trigger-releases

Conversation

@lukastaegert
Copy link
Member

Rollup Plugin Name: {name}

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

This adds a small unimportant change to all dependencies to hopefully trigger automatic releases.

@shellscape
Copy link
Collaborator

I'm really confused what the purpose of this PR is. It looks like the rollup version is being downgraded?

@lukastaegert lukastaegert merged commit 282509d into master Oct 20, 2022
@lukastaegert lukastaegert deleted the trigger-releases branch October 20, 2022 17:03
@lukastaegert
Copy link
Member Author

lukastaegert commented Oct 20, 2022

It is not really a downgrade because the latest version is still in the range. But I need to have an actual change in every single package to trigger the release script, which again will then hopefully find the commit with the actual change to release. Or so goes the theory.
And this was easy to do with find-and-replace. Unless this message does not trigger a release. Then I do another one to revert this one...

@shellscape
Copy link
Collaborator

Can you PLEASE stop merging without approvals from the rest of the maintainers? This one is messed up too.

@shellscape
Copy link
Collaborator

I've cancelled the action for this PR and reset master to the previous commit. See #1326 (comment)

Because #1326 wasn't merged correctly, we now need to clean up the repo's commits and reapply PRs correctly. So I'd ask you to take a pause until I can get to cleaning this up this afternoon.

@lukastaegert
Copy link
Member Author

lukastaegert commented Oct 20, 2022

Ok, if you had the release run through, then all packages would have been released with correct changelog. I will not put any more work into this.

@shellscape
Copy link
Collaborator

I'm sorry but you're mistaken. This PR would not have released any plugins. I commented in #1326 about what the commit message would need to be to make that happen.

I've also asked for collaboration with sweeping changes like this, and the self-merges are bypassing the review process in the repo, which isn't cool. No one is asking you to stop or walk away from this, just to slow down and respect the review process. A little patience would have let us catch the mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants