[ROMM-2796] Add check to overwrite media assets

[gantoine]

Description
^{Explain the changes or enhancements you are proposing with this pull request.}

Only overwrite media assets if the corresponding *_url value/list has changed.

Fixes #2796

Checklist
^{Please check all that apply.}

• I've tested the changes locally
• I've updated relevant comments
• I've assigned reviewers for this PR
• I've added unit tests that cover the changes

[gemini-code-assist]

Summary of Changes

Hello @gantoine, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request optimizes the media asset management within the ROM system by implementing conditional overwriting for covers, manuals, and screenshots. Previously, these assets were unconditionally re-downloaded and overwritten during updates or identification. Now, the system intelligently checks if the associated URLs have actually changed before performing an overwrite, thereby reducing unnecessary I/O operations and improving overall efficiency.

Highlights

• Conditional Media Asset Overwriting: Media assets, including screenshots, covers, and manuals, are now only overwritten if their corresponding URLs have changed, preventing redundant file operations.
• Pydash Integration: The pydash library has been introduced to efficiently compare lists of screenshot URLs, determining if an overwrite is necessary.
• Refactored Update Logic: The logic for handling cover and manual updates in the update_rom function has been simplified by removing redundant exists checks and directly passing a conditional overwrite flag.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Test Results

702 tests  ±0   701 ✅ ±0   1m 26s ⏱️ ±0s
  1 suites ±0     1 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit e0f0792. ± Comparison against base commit df65e4b.

♻️ This comment has been updated with latest results.

[github-actions]

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines	Covered	Coverage	Threshold	Status
12120	7885	65%	0%	🟢

New Files

No new covered files...

Modified Files

File	Coverage	Status
backend/endpoints/rom.py	44%	🟢
backend/endpoints/sockets/scan.py	26%	🟢
TOTAL	35%	🟢

updated for commit: e0f0792 by action🐍

[gemini-code-assist]

Code Review

This pull request aims to optimize media asset handling by only overwriting them when their URLs change. The implementation for covers and manuals looks good and simplifies the existing code. However, the logic for handling screenshots has a flaw: it only detects when new screenshots are added, not when they are removed. This can lead to stale screenshot files remaining on the filesystem. I've provided comments in both affected files with a suggested fix using a symmetric difference check to correctly identify all changes in the screenshot list.