Skip to content

[ROMM-2796] Add check to overwrite media assets #2851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gantoine merged 2 commits into from
Jan 2, 2026
Merged

[ROMM-2796] Add check to overwrite media assets #2851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b926a33
[ROMM-2796] Add check to overwrite media assets
gantoine Jan 2, 2026
e0f0792
cahnges from bot review
gantoine Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 28 additions & 34 deletions backend/endpoints/rom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from urllib.parse import quote
from zipfile import ZIP_DEFLATED, ZIP_STORED, ZipFile, ZipInfo

import pydash
from anyio import Path, open_file
from fastapi import (
Body,
Expand Down Expand Up @@ -52,7 +53,6 @@
from handler.database import db_platform_handler, db_rom_handler
from handler.database.base_handler import sync_session
from handler.filesystem import fs_resource_handler, fs_rom_handler
from handler.filesystem.base_handler import CoverSize
from handler.metadata import (
meta_flashpoint_handler,
meta_igdb_handler,
Expand Down Expand Up @@ -1074,10 +1074,12 @@ async def update_rom(
elif rom.igdb_id and not cleaned_data["igdb_id"]:
cleaned_data.update({"igdb_id": None, "igdb_metadata": {}})

if cleaned_data.get("url_screenshots", []):
url_screenshots = cleaned_data.get("url_screenshots", [])
screenshots_changed = pydash.xor(url_screenshots, rom.url_screenshots or [])
if url_screenshots:
path_screenshots = await fs_resource_handler.get_rom_screenshots(
rom=rom,
overwrite=True,
overwrite=bool(screenshots_changed),
url_screenshots=cleaned_data.get("url_screenshots", []),
)
cleaned_data.update(
Expand Down Expand Up @@ -1124,39 +1126,31 @@ async def update_rom(
)
else:
url_cover = data.get("url_cover", rom.url_cover)
if url_cover != rom.url_cover or not fs_resource_handler.cover_exists(
rom, CoverSize.BIG
):
path_cover_s, path_cover_l = await fs_resource_handler.get_cover(
entity=rom,
overwrite=True,
url_cover=str(url_cover),
)
cleaned_data.update(
{
"url_cover": url_cover,
"path_cover_s": path_cover_s,
"path_cover_l": path_cover_l,
}
)
else:
cleaned_data.update({"url_cover": rom.url_cover})
path_cover_s, path_cover_l = await fs_resource_handler.get_cover(
entity=rom,
overwrite=url_cover != rom.url_cover,
url_cover=str(url_cover),
)
cleaned_data.update(
{
"url_cover": url_cover,
"path_cover_s": path_cover_s,
"path_cover_l": path_cover_l,
}
)

url_manual = data.get("url_manual", rom.url_manual)
if url_manual != rom.url_manual or not fs_resource_handler.manual_exists(rom):
path_manual = await fs_resource_handler.get_manual(
rom=rom,
overwrite=True,
url_manual=str(url_manual) if url_manual else None,
)
cleaned_data.update(
{
"url_manual": url_manual,
"path_manual": path_manual,
}
)
else:
cleaned_data.update({"url_manual": rom.url_manual})
path_manual = await fs_resource_handler.get_manual(
rom=rom,
overwrite=url_manual != rom.url_manual,
url_manual=str(url_manual) if url_manual else None,
)
cleaned_data.update(
{
"url_manual": url_manual,
"path_manual": path_manual,
}
)

# Handle RetroAchievements badges when the ID has changed
if cleaned_data["ra_id"] and int(cleaned_data["ra_id"]) != rom.ra_id:
Expand Down
10 changes: 7 additions & 3 deletions backend/endpoints/sockets/scan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
from itertools import batched
from typing import Any, Final

import pydash
import socketio # type: ignore
from rq import Worker
from rq.job import Job
Expand Down Expand Up @@ -366,19 +367,22 @@ async def _identify_rom(

path_cover_s, path_cover_l = await fs_resource_handler.get_cover(
entity=_added_rom,
overwrite=True,
overwrite=_added_rom.url_cover != rom.url_cover,
url_cover=_added_rom.url_cover,
)

path_manual = await fs_resource_handler.get_manual(
rom=_added_rom,
overwrite=True,
overwrite=_added_rom.url_manual != rom.url_manual,
url_manual=_added_rom.url_manual,
)

screenshots_changed = pydash.xor(
_added_rom.url_screenshots or [], rom.url_screenshots or []
)
path_screenshots = await fs_resource_handler.get_rom_screenshots(
rom=_added_rom,
overwrite=True,
overwrite=bool(screenshots_changed),
url_screenshots=_added_rom.url_screenshots,
)

Expand Down
Loading