Skip to content

Comments

Adjust reference for Aarch64#2120

Merged
couet merged 1 commit intoroot-project:masterfrom
ellert:stressgraphics-aarch64
Jun 29, 2018
Merged

Adjust reference for Aarch64#2120
couet merged 1 commit intoroot-project:masterfrom
ellert:stressgraphics-aarch64

Conversation

@ellert
Copy link
Contributor

@ellert ellert commented May 31, 2018

No description provided.

@ellert ellert requested a review from Axel-Naumann as a code owner May 31, 2018 08:24
@phsft-bot
Copy link

Can one of the admins verify this patch?

@Axel-Naumann
Copy link
Member

Thanks, Mattias!

We're running and passing on AArch64: http://cdash.cern.ch/viewTest.php?onlypassed&buildid=515508

What's different about yours?

@Axel-Naumann Axel-Naumann requested a review from couet May 31, 2018 18:21
@ellert
Copy link
Contributor Author

ellert commented Jun 1, 2018

The problem only happens on Fedora 28 and 29, not with Fedora 27 or earlier or EPEL 7.

@Axel-Naumann
Copy link
Member

@phsft-bot build!

@phsft-bot
Copy link

Starting build on slc6/gcc48, slc6/gcc62, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

Copy link
Member

@Axel-Naumann Axel-Naumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but let's see what roottest says on the other platforms, and what @couet says!

@phsft-bot
Copy link

Build failed on centos7/gcc7.
See console output.

Warnings:

  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/core/newdelete/src/NewDelete.cxx:217:11: warning: ‘operator new’ must not return NULL unless it is declared ‘throw()’ (or -fcheck-new is in effect)
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/core/newdelete/src/NewDelete.cxx:214:27: warning: unused parameter ‘size’ [-Wunused-parameter]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/core/newdelete/src/NewDelete.cxx:214:50: warning: unused parameter ‘al’ [-Wunused-parameter]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/core/newdelete/src/NewDelete.cxx:220:27: warning: unused parameter ‘size’ [-Wunused-parameter]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/core/newdelete/src/NewDelete.cxx:220:50: warning: unused parameter ‘al’ [-Wunused-parameter]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/core/newdelete/src/NewDelete.cxx:300:28: warning: unused parameter ‘ptr’ [-Wunused-parameter]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/core/newdelete/src/NewDelete.cxx:300:50: warning: unused parameter ‘al’ [-Wunused-parameter]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/core/newdelete/src/NewDelete.cxx:304:28: warning: unused parameter ‘ptr’ [-Wunused-parameter]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/core/newdelete/src/NewDelete.cxx:304:50: warning: unused parameter ‘al’ [-Wunused-parameter]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/core/newdelete/src/NewDelete.cxx:344:11: warning: ‘operator new’ must not return NULL unless it is declared ‘throw()’ (or -fcheck-new is in effect)

And 8 more

Failing tests:

@phsft-bot
Copy link

Build failed on slc6-i686/gcc49.
See console output.

Failing tests:

@couet
Copy link
Member

couet commented Jun 19, 2018

Hi Matthias, sorry for the late reply. I have recently changed the stressgraphics ref file. Can you take the new one and verify it on your machine ? I guess you will need to submit a new version of the ref file in this PR.

@ellert
Copy link
Contributor Author

ellert commented Jun 29, 2018

Since this PR was submitted there has been 1 commit to the stressGraphics.ref file in master. That commit changed the numbers for test number 27. This PR changes the results for test number 32, 33, 38 and 40. This is sufficiently far away from 27 that the PR can still be merged without conflicts, so there is no need to rebase. The PR was created to address issues found when building root 6.12, but the same results apply also for root 6.14.

@couet
Copy link
Member

couet commented Jun 29, 2018

@phsft-bot build

@phsft-bot
Copy link

Starting build on slc6/gcc48, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dimt=ON -Dccache=ON
How to customize builds

@couet couet merged commit e24584a into root-project:master Jun 29, 2018
Copy link
Member

@couet couet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@ellert ellert deleted the stressgraphics-aarch64 branch June 29, 2018 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants