Fix action generation #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, we were not generating code for: * `<goal_name>_SendGoal_Request` * `<goal_name>_SendGoal_Response` * `<goal_name>_GetResult_Request` * `<goal_name>_GetResult_Response` Before, code was generated for `<goal_name>_Send_Goal`, but this code was duplicate to the code in <goal_name>FeedbackMessage, which caused unwanted behaviour since it was not meant to be generated there.
jacobperron
pushed a commit
to osrf/ros2_java
that referenced
this pull request
Nov 10, 2020
Generate action code for: * `<goal_name>_SendGoal_Request` * `<goal_name>_SendGoal_Response` * `<goal_name>_GetResult_Request` * `<goal_name>_GetResult_Response`
jacobperron
pushed a commit
to osrf/ros2_java
that referenced
this pull request
Nov 10, 2020
Generate action code for: * `<goal_name>_SendGoal_Request` * `<goal_name>_SendGoal_Response` * `<goal_name>_GetResult_Request` * `<goal_name>_GetResult_Response`
jacobperron
pushed a commit
to osrf/ros2_java
that referenced
this pull request
Nov 10, 2020
Generate action code for: * `<goal_name>_SendGoal_Request` * `<goal_name>_SendGoal_Response` * `<goal_name>_GetResult_Request` * `<goal_name>_GetResult_Response`
jacobperron
pushed a commit
to osrf/ros2_java
that referenced
this pull request
Nov 10, 2020
Generate action code for: * `<goal_name>_SendGoal_Request` * `<goal_name>_SendGoal_Response` * `<goal_name>_GetResult_Request` * `<goal_name>_GetResult_Response`
jacobperron
pushed a commit
to osrf/ros2_java
that referenced
this pull request
Nov 10, 2020
Generate action code for: * `<goal_name>_SendGoal_Request` * `<goal_name>_SendGoal_Response` * `<goal_name>_GetResult_Request` * `<goal_name>_GetResult_Response`
jacobperron
pushed a commit
that referenced
this pull request
May 17, 2021
Generate action code for: * `<goal_name>_SendGoal_Request` * `<goal_name>_SendGoal_Response` * `<goal_name>_GetResult_Request` * `<goal_name>_GetResult_Response`
jacobperron
pushed a commit
that referenced
this pull request
May 17, 2021
Generate action code for: * `<goal_name>_SendGoal_Request` * `<goal_name>_SendGoal_Response` * `<goal_name>_GetResult_Request` * `<goal_name>_GetResult_Response`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we were not generating code for:
<action_goal_name>_SendGoal_Request<action_goal_name>_SendGoal_Response<action_goal_name>_GetResult_Request<action_goal_name>_GetResult_ResponseBefore, code was generated for
<action_goal_name>_Send_Goal, but this code was duplicate to the code in<action_goal_name>FeedbackMessage, which caused unwanted behaviour since it was not meant to be generated there.