change code order(methodId 'add' in for loop) #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobperron
approved these changes
Dec 4, 2020
Contributor
jacobperron
left a comment
jacobperron
left a comment
There was a problem hiding this comment.
LGTM.
I'm looking into the CI failure, which appears unrelated.
Contributor
|
@pluris Can you try rebasing your changes on the latest version of the |
pluris
force-pushed
the
dev/dashing_change_code_order
branch
from
9285d70 to
6d0ddfc
Compare
Contributor
Author
|
@jacobperron okay, I rebased it. |
Contributor
|
@pluris Thanks for the patch! |
jacobperron
pushed a commit
to osrf/ros2_java
that referenced
this pull request
Dec 8, 2020
jacobperron
pushed a commit
to osrf/ros2_java
that referenced
this pull request
Jan 5, 2021
jacobperron
pushed a commit
that referenced
this pull request
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'jmethodID jlist@(member.name)_add_mid' is not required in the for loop.
In my opinion, it should be declared outside for loop.