rcl_get_error_string_safe to rcl_get_error_string #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in rcl/error_handling.h only rcl_get_error_string_safe.
jacobperron
approved these changes
Feb 3, 2020
Contributor
jacobperron
left a comment
jacobperron
left a comment
There was a problem hiding this comment.
Doh, I must have had a cached definition from Bouncy and missed this. Thanks!
Contributor
|
My mistake, I thought this was targeting my branch #75, which already contains the necessary changes 🙃 To avoid rebase issues with my pull request, I've undone this merge. Sorry for mess. |
Contributor
Author
|
I didn't know you already do this work. Sorry for the mess. I will compile your branch. |
ivanpauno
added a commit
that referenced
this pull request
Oct 28, 2021
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron
pushed a commit
that referenced
this pull request
May 17, 2022
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in rcl/error_handling.h only rcl_get_error_string_safe.