Add GitHub workflow for Dashing #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@jacobperron could you rebase this now that the other PRs are merged? Thanks! |
Closed
Using the ros-tooling custom GitHub actions Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
force-pushed
the
jacob/dashing_workflow
branch
from
ebc471d to
0917c42
Compare
Contributor
Author
|
@esteve Thanks for the reviews and merging! I've rebased this branch. |
Member
|
@jacobperron no worries, sorry for the delay. It seems that https://raw.githubusercontent.com/ros2-java/ros2_java/jacob/update_desktop_repos/ros2_java_desktop.repos can't be found and therefore the GitHub action fails, perhaps the URL should be https://raw.githubusercontent.com/ros2-java/ros2_java/master/ros2_java_desktop.repos or https://raw.githubusercontent.com/ros2-java/ros2_java/dashing/ros2_java_desktop.repos, right? |
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Contributor
Author
|
Yep, the URL should change now that the file is merged to |
Closed
Contributor
Author
|
@esteve Shall we merge this? I can add Windows and Android builds to CI in a follow-up. |
Member
|
@jacobperron thanks! Yeah, could you create a follow-up ticket so we can track it? |
This was referenced Apr 7, 2020
Contributor
Author
Member
|
@jacobperron thanks! 🙂 |
jacobperron
added a commit
that referenced
this pull request
May 2, 2020
* Add dashing workflow Using the ros-tooling custom GitHub actions Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Update repos file URL Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
referenced
this pull request
in osrf/ros2_java
Aug 12, 2020
* Add dashing workflow Using the ros-tooling custom GitHub actions Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Update repos file URL Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
referenced
this pull request
in osrf/ros2_java
Aug 13, 2020
* Add GitHub workflow for Dashing (#96) * Add dashing workflow Using the ros-tooling custom GitHub actions Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Update repos file URL Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Update workflow file for Foxy Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Update desktop repos file for Foxy Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Bump action ros-tooling action versions Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Try earlier version of action-ros-ci Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Fix curl error Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Remove slash Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Add checkout action Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Switch to fork of ament_java Contains patch for Eloquent and Foxy. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
that referenced
this pull request
May 17, 2021
* Add dashing workflow Using the ros-tooling custom GitHub actions Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Update repos file URL Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
that referenced
this pull request
May 17, 2021
* Add dashing workflow Using the ros-tooling custom GitHub actions Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Update repos file URL Signed-off-by: Jacob Perron <jacob@openrobotics.org>
ivanpauno
referenced
this pull request
in osrf/ros2_java
May 17, 2021
* Add GitHub workflow for Dashing (#96) * Add dashing workflow Using the ros-tooling custom GitHub actions Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Update repos file URL Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Update workflow file for Foxy Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Update desktop repos file for Foxy Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Bump action ros-tooling action versions Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Try earlier version of action-ros-ci Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Fix curl error Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Remove slash Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Add checkout action Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Switch to fork of ament_java Contains patch for Eloquent and Foxy. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on several outstanding PRs for CI to pass: #76 #93 #94
Opening for visibility. Will rebase after the above referenced PRs are merged.
This adds a GitHub workflow to build and test ros2_java for Dashing. When we're ready to merge this with the master and branch for Eloquent / Foxy, we can update the workflow file accordingly.
I believe adding jobs for Windows and macOS should be straight forward, which I'll look into adding next.
Similarly, adding jobs for Android builds is on my TODO list.