Conversation
tfoote
requested changes
Feb 7, 2019
Contributor
tfoote
left a comment
tfoote
left a comment
There was a problem hiding this comment.
Yes, using the static method is sub-optimal, it won't get . The correct solution is not to construct a new Clock object but call get_clock() on the member node_. Or the convenience method now() on the node which does that under the hood
Constructing a Clock object but not attaching a time source to it is basically the same as the static method. I believe that API didn't exist when this was first implemented.
Contributor
Author
|
@tfoote Thanks for the review. Sorry couldn't apply the changes earlier. |
Contributor
|
Thanks for the update @sagniknitr Triggering CI:
|
tfoote
approved these changes
Feb 15, 2019
nuclearsandwich
added a commit
to ros/rosdistro
that referenced
this pull request
Apr 14, 2019
Increasing version of package(s) in repository `geometry2` to `0.11.0-1`: - upstream repository: https://github.com/ros2/geometry2.git - release repository: https://github.com/ros2-gbp/geometry2-release.git - distro file: `dashing/distribution.yaml` - bloom version: `0.8.0` - previous version for package: `null` ## tf2 - No changes ## tf2_eigen ``` * Updated to use ament_target_dependencies where possible. (#98 <ros2/geometry2#98>) * Contributors: ivanpauno ``` ## tf2_geometry_msgs ``` * Updated to use ament_target_dependencies where possible. (#98 <ros2/geometry2#98>) ``` ## tf2_msgs - No changes ## tf2_ros ``` * Updated to use node inteface pointers in the MessageFilter class. (#96 <ros2/geometry2#96>) * Updated message_filter.h. (#91 <ros2/geometry2#91>) * Contributors: Michael Jeronimo, Sagnik Basu ``` ## tf2_sensor_msgs - No changes
vmayoral
pushed a commit
to AcutronicRobotics/geometry2
that referenced
this pull request
Apr 26, 2019
* Use correct method to get node time.
andre-rosa
pushed a commit
to andre-rosa/rosdistro
that referenced
this pull request
May 3, 2019
Increasing version of package(s) in repository `geometry2` to `0.11.0-1`: - upstream repository: https://github.com/ros2/geometry2.git - release repository: https://github.com/ros2-gbp/geometry2-release.git - distro file: `dashing/distribution.yaml` - bloom version: `0.8.0` - previous version for package: `null` ## tf2 - No changes ## tf2_eigen ``` * Updated to use ament_target_dependencies where possible. (ros#98 <ros2/geometry2#98>) * Contributors: ivanpauno ``` ## tf2_geometry_msgs ``` * Updated to use ament_target_dependencies where possible. (ros#98 <ros2/geometry2#98>) ``` ## tf2_msgs - No changes ## tf2_ros ``` * Updated to use node inteface pointers in the MessageFilter class. (ros#96 <ros2/geometry2#96>) * Updated message_filter.h. (ros#91 <ros2/geometry2#91>) * Contributors: Michael Jeronimo, Sagnik Basu ``` ## tf2_sensor_msgs - No changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rclcpp::Time Clock "now" call seemed wrong. This is the correct way to do it seems.