fix: strip empty messages on OpenAI->Claude translation#295
fix: strip empty messages on OpenAI->Claude translation#295KooshaPari wants to merge 1 commit intorouter-for-me:mainfrom
Conversation
Cherry-picked from merge/1698-strip-empty-messages-openai-to-claude into aligned base
Summary of ChangesHello @KooshaPari, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the translation logic from OpenAI to Claude API requests by explicitly filtering out and skipping any text content parts that are empty strings. This ensures that only meaningful text content is passed to the Claude API, enhancing the robustness and reliability of the translation layer by preventing issues caused by empty message components. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where empty messages were not being stripped during the translation from OpenAI to Claude format. The changes correctly add checks to skip empty text content parts for system, user, and assistant messages. I've added one comment regarding code duplication which could be addressed in a follow-up to improve maintainability.
| textContent := part.Get("text").String() | ||
| if textContent == "" { | ||
| return true | ||
| } | ||
| textPart := `{"type":"text","text":""}` | ||
| textPart, _ = sjson.Set(textPart, "text", part.Get("text").String()) | ||
| textPart, _ = sjson.Set(textPart, "text", textContent) | ||
| out, _ = sjson.SetRaw(out, fmt.Sprintf("messages.%d.content.-1", systemMessageIndex), textPart) |
There was a problem hiding this comment.
This logic to handle empty text parts is duplicated for system messages here, and for user/assistant messages later in this file (lines 185-191). To improve maintainability, consider refactoring this into a helper function in a future change.
KooshaPari
deleted the
feat/clean-base-1698-strip-empty-messages-rebase
branch
1 participant
Cherry-picks the same behavioral fix from router-for-me#1698 onto a clean base of router-for-me/CLIProxyAPIPlus main.\n\nThis avoids the large historic divergence from the previous branch and keeps only the intended one-file change.