Skip to content

fix: strip empty messages on OpenAI->Claude translation #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KooshaPari wants to merge 1 commit into from
Closed

fix: strip empty messages on OpenAI->Claude translation #295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions internal/translator/claude/openai/chat-completions/claude_openai_request.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,12 @@ func ConvertOpenAIRequestToClaude(modelName string, inputRawJSON []byte, stream
} else if contentResult.Exists() && contentResult.IsArray() {
contentResult.ForEach(func(_, part gjson.Result) bool {
if part.Get("type").String() == "text" {
textContent := part.Get("text").String()
if textContent == "" {
return true
}
textPart := `{"type":"text","text":""}`
textPart, _ = sjson.Set(textPart, "text", part.Get("text").String())
textPart, _ = sjson.Set(textPart, "text", textContent)
out, _ = sjson.SetRaw(out, fmt.Sprintf("messages.%d.content.-1", systemMessageIndex), textPart)
Comment on lines +159 to 165
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This logic to handle empty text parts is duplicated for system messages here, and for user/assistant messages later in this file (lines 185-191). To improve maintainability, consider refactoring this into a helper function in a future change.

}
return true
Expand All @@ -178,8 +182,12 @@ func ConvertOpenAIRequestToClaude(modelName string, inputRawJSON []byte, stream

switch partType {
case "text":
textContent := part.Get("text").String()
if textContent == "" {
return true
}
textPart := `{"type":"text","text":""}`
textPart, _ = sjson.Set(textPart, "text", part.Get("text").String())
textPart, _ = sjson.Set(textPart, "text", textContent)
msg, _ = sjson.SetRaw(msg, "content.-1", textPart)

case "image_url":
Expand Down
Loading