Skip to content

Add hexstring tests for frame header encoding#104

Merged
stevegury merged 4 commits intorsocket:masterfrom
yschimke:setup_flags
Jul 27, 2016
Merged

Add hexstring tests for frame header encoding#104
stevegury merged 4 commits intorsocket:masterfrom
yschimke:setup_flags

Conversation

@yschimke
Copy link
Copy Markdown
Member

Before vs After

         +-------------------------------------------------+
         |  0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f |
+--------+-------------------------------------------------+----------------+
|00000000| 00 00 00 1a 00 01 00 20 00 00 00 00 00 00 00 00 |....... ........|
|00000010| 00 00 03 e8 00 00 00 00 00 00                   |..........      |
+--------+-------------------------------------------------+----------------+


         +-------------------------------------------------+
         |  0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f |
+--------+-------------------------------------------------+----------------+
|00000000| 00 00 00 1a 00 01 20 00 00 00 00 00 00 00 00 00 |...... .........|
|00000010| 00 00 03 e8 00 00 00 00 00 00                   |..........      |
+--------+-------------------------------------------------+----------------+

@yschimke
Copy link
Copy Markdown
Member Author

Not sure what you think about unit testing the hex dump of the header bytes for frames?

    assertEquals(
        "0000003a000130000000000000000000000003e90000138d",
        ByteBufUtil.hexDump(encodedFrame.getByteBuffer().array(), 0, 24));

@yschimke yschimke changed the title move setup flags 2 bytes to the left move setup flags 2 nibbles to the left Jun 24, 2016
@stevegury
Copy link
Copy Markdown
Member

I like the idea of unit-testing the hex dump: easy to spot and fix errors !

@stevegury
Copy link
Copy Markdown
Member

👍
If you don't mind, I propose to batch all breaking changes.
So let's keep the PR open for now.

@stevegury
Copy link
Copy Markdown
Member

@yschimke could you merge master?

@yschimke yschimke changed the title move setup flags 2 nibbles to the left Add hexstring tests for frame header encoding Jul 27, 2016
@stevegury stevegury merged commit 91c0858 into rsocket:master Jul 27, 2016
@yschimke yschimke deleted the setup_flags branch July 27, 2016 16:23
xytosis pushed a commit to xytosis/reactivesocket-java that referenced this pull request Aug 6, 2016
* move setup flags 2 bytes to the left

* unit test frame headers

* reformat
ilayaperumalg pushed a commit to ilayaperumalg/rsocket-java that referenced this pull request Dec 26, 2017
* Clarify Error Frame docs

* string handling simplified (rsocket#105)

* us-ascii

* should

* should 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants