Add hexstring tests for frame header encoding#104
Merged
stevegury merged 4 commits intorsocket:masterfrom Jul 27, 2016
yschimke:setup_flags
Merged
Add hexstring tests for frame header encoding#104stevegury merged 4 commits intorsocket:masterfrom yschimke:setup_flags
stevegury merged 4 commits intorsocket:masterfrom
yschimke:setup_flags
Conversation
Member
Author
|
Not sure what you think about unit testing the hex dump of the header bytes for frames? |
Member
|
I like the idea of unit-testing the hex dump: easy to spot and fix errors ! |
Member
|
👍 |
Member
|
@yschimke could you merge master? |
xytosis
pushed a commit
to xytosis/reactivesocket-java
that referenced
this pull request
Aug 6, 2016
* move setup flags 2 bytes to the left * unit test frame headers * reformat
ilayaperumalg
pushed a commit
to ilayaperumalg/rsocket-java
that referenced
this pull request
Dec 26, 2017
* Clarify Error Frame docs * string handling simplified (rsocket#105) * us-ascii * should * should 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before vs After