Ignoring ClosedChannelException from the error stream.#105
Merged
stevegury merged 1 commit intorsocket:masterfrom Jun 26, 2016
Merged
Ignoring ClosedChannelException from the error stream.#105stevegury merged 1 commit intorsocket:masterfrom
ClosedChannelException from the error stream.#105stevegury merged 1 commit intorsocket:masterfrom
Conversation
Problem Since `ReactiveSocket` reads and writes from a transport connection, it is completely expected that at some point the underlying connection may have been severed. In such a case, both the read and write will fail on the connection. This pollutes logs of applications that directly log the error stream (as expected). Modification Since, this is kind of an "expected" exception, there is no point to send this to the error stream. This change adds a filter to the error stream to filter any known exceptions (as of today, it is only `ClosedChannelException`) PS: We currently do not unsubscribe from the input (and stop writing) when `ReactiveSocket` is explicitly closed. This change does not mean, we do not clean that up.
Member
|
You beat me to it, I also had a fix for this! |
ilayaperumalg
pushed a commit
to ilayaperumalg/rsocket-java
that referenced
this pull request
Dec 26, 2017
ilayaperumalg
pushed a commit
to ilayaperumalg/rsocket-java
that referenced
this pull request
Dec 26, 2017
* Clarify Error Frame docs * string handling simplified (rsocket#105) * us-ascii * should * should 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since
ReactiveSocketreads and writes from a transport connection, it is completely expected that at some point the underlying connection may have been severed. In such a case, both the read and write will fail on the connection. This pollutes logs of applications that directly log the error stream (as expected).Modification
Since, this is kind of an "expected" exception, there is no point to send this to the error stream.
This change adds a filter to the error stream to filter any known exceptions (as of today, it is only
ClosedChannelException)PS: We currently do not unsubscribe from the input (and stop writing) when
ReactiveSocketis explicitly closed. This change does not mean, we do not clean that up.