Local transport now uses tcp.#106
Closed
NiteshKant wants to merge 1 commit intorsocket:masterfrom
Closed
Conversation
| /** | ||
| * An implementation of {@link Payload} | ||
| */ | ||
| public class PayloadImpl implements Payload { |
Member
There was a problem hiding this comment.
This being available is very helpful
Member
|
This looks good, but one of the test is failing. |
Contributor
Author
|
@stevegury yes, there is some flakiness in the tests with local channel. I will get back to this tomorrow may be. |
Problem Local transport was using a custom local socket implementation. Netty provides a `LocalChannel` abstraction that can be used. Modification Modified reactivesocket-transport-local` to use `reactivesocket-transport-tcp`. Refactored common test classes to `reactivesocket-test` module so they can be used in both tcp and local transport without code duplication.
NiteshKant
added a commit
to NiteshKant/reactivesocket-java
that referenced
this pull request
Jul 7, 2016
Problem This is a split of PR rsocket#106 to make local transport use TCP. There seems to be some issue in netty's local transport which creates race-conditions and causes test failures. These refactor has some changes that are not necessarily related to local transport but makes the usage better. Modification Refactored common test classes to `reactivesocket-test` module so they can be used in both tcp and local transport without code duplication. Added `PayloadImpl` as a utility implementation of `Payload`.
Contributor
Author
|
Closing this in favor of #134 which picks all changes from here other than actually changing local transport. |
NiteshKant
added a commit
that referenced
this pull request
Jul 7, 2016
Problem This is a split of PR #106 to make local transport use TCP. There seems to be some issue in netty's local transport which creates race-conditions and causes test failures. These refactor has some changes that are not necessarily related to local transport but makes the usage better. Modification Refactored common test classes to `reactivesocket-test` module so they can be used in both tcp and local transport without code duplication. Added `PayloadImpl` as a utility implementation of `Payload`.
NiteshKant
added a commit
to NiteshKant/reactivesocket-java
that referenced
this pull request
Jul 10, 2016
Problem This is a split of PR rsocket#106 to make local transport use TCP. There seems to be some issue in netty's local transport which creates race-conditions and causes test failures. These refactor has some changes that are not necessarily related to local transport but makes the usage better. Modification Refactored common test classes to `reactivesocket-test` module so they can be used in both tcp and local transport without code duplication. Added `PayloadImpl` as a utility implementation of `Payload`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Local transport was using a custom local socket implementation.
Netty provides a
LocalChannelabstraction that can be used.Modification
Modified
reactivesocket-transport-localto usereactivesocket-transport-tcp.Refactored common test classes to
reactivesocket-testmodule so they can be used in both tcp and local transport without code duplication.