Refactor of TCP transport.#134
Merged
NiteshKant merged 1 commit intorsocket:masterfrom Jul 7, 2016
Merged
Conversation
Problem This is a split of PR rsocket#106 to make local transport use TCP. There seems to be some issue in netty's local transport which creates race-conditions and causes test failures. These refactor has some changes that are not necessarily related to local transport but makes the usage better. Modification Refactored common test classes to `reactivesocket-test` module so they can be used in both tcp and local transport without code duplication. Added `PayloadImpl` as a utility implementation of `Payload`.
Contributor
Author
|
Since this is a subset of PR #106 which got a 👍 I am just merging this now. |
Member
|
Are you sure the issues for Local Transport were not because you were reusing the same local DuplexConnection over all tests? I haven't noticed any issues so far but I was using the test name in the config for each test, so never reusing connections. |
Contributor
Author
Member
|
I was looking at the tests before changes, but might be the wrong tests :( |
NiteshKant
added a commit
to NiteshKant/reactivesocket-java
that referenced
this pull request
Jul 10, 2016
Problem This is a split of PR rsocket#106 to make local transport use TCP. There seems to be some issue in netty's local transport which creates race-conditions and causes test failures. These refactor has some changes that are not necessarily related to local transport but makes the usage better. Modification Refactored common test classes to `reactivesocket-test` module so they can be used in both tcp and local transport without code duplication. Added `PayloadImpl` as a utility implementation of `Payload`.
ilayaperumalg
pushed a commit
to ilayaperumalg/rsocket-java
that referenced
this pull request
Dec 26, 2017
Adding text as suggested by Todd that permits an implementation to move management of streamId to the underlying transport.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This is a split of PR #106 to make local transport use TCP.
There seems to be some issue in netty's local transport which creates race-conditions and causes test failures.
These refactor has some changes that are not necessarily related to local transport but makes the usage better.
Modification
Refactored common test classes to
reactivesocket-testmodule so they can be used in both tcp and local transport without code duplication.Added
PayloadImplas a utility implementation ofPayload.