FailingReactiveSocket violates spec#136
Merged
stevegury merged 1 commit intorsocket:masterfrom Jul 11, 2016
Merged
Conversation
#### Problem `FailingReactiveSocket` was invoking `Subscriber.onError()` without calling `onSubscribe()` which is invalid as per reactive-streams spec: https://github.com/reactive-streams/reactive-streams-jvm#api-components ``` This means that onSubscribe is always signalled, followed by a possibly unbounded number of onNext signals (as requested by Subscriber) followed by an onError signal if there is a failure, or an onComplete signal when no more elements are available—all as long as the Subscription is not cancelled. ``` #### Modification Modified to use `Publishers.error()` which follows the spec correctly. #### Result Better adherence of spec, happy users :)
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
FailingReactiveSocketwas invokingSubscriber.onError()without callingonSubscribe()which is invalid as per reactive-streams spec:https://github.com/reactive-streams/reactive-streams-jvm#api-components
Modification
Modified to use
Publishers.error()which follows the spec correctly.Result
Better adherence of spec, happy users :)