Skip to content

FailingReactiveSocket violates spec #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevegury merged 1 commit into from
Jul 11, 2016
Merged

FailingReactiveSocket violates spec #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions reactivesocket-client/src/main/java/io/reactivesocket/client/LoadBalancer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import io.reactivesocket.client.stat.Ewma;
import io.reactivesocket.exceptions.TimeoutException;
import io.reactivesocket.exceptions.TransportException;
import io.reactivesocket.internal.Publishers;
import io.reactivesocket.rx.Completable;
import io.reactivesocket.client.stat.FrugalQuantile;
import io.reactivesocket.client.stat.Quantile;
Expand Down Expand Up @@ -629,38 +630,42 @@ public void onComplete() {}
* when dealing with edge cases.
*/
private static class FailingReactiveSocket implements ReactiveSocket {

@SuppressWarnings("ThrowableInstanceNeverThrown")
private static final NoAvailableReactiveSocketException NO_AVAILABLE_RS_EXCEPTION =
new NoAvailableReactiveSocketException();

private static final Publisher<Void> errorVoid = Publishers.error(NO_AVAILABLE_RS_EXCEPTION);
private static final Publisher<Payload> errorPayload = Publishers.error(NO_AVAILABLE_RS_EXCEPTION);

@Override
public Publisher<Void> fireAndForget(Payload payload) {
return subscriber -> subscriber.onError(NO_AVAILABLE_RS_EXCEPTION);
return errorVoid;
}

@Override
public Publisher<Payload> requestResponse(Payload payload) {
return subscriber -> subscriber.onError(NO_AVAILABLE_RS_EXCEPTION);
return errorPayload;
}

@Override
public Publisher<Payload> requestStream(Payload payload) {
return subscriber -> subscriber.onError(NO_AVAILABLE_RS_EXCEPTION);
return errorPayload;
}

@Override
public Publisher<Payload> requestSubscription(Payload payload) {
return subscriber -> subscriber.onError(NO_AVAILABLE_RS_EXCEPTION);
return errorPayload;
}

@Override
public Publisher<Payload> requestChannel(Publisher<Payload> payloads) {
return subscriber -> subscriber.onError(NO_AVAILABLE_RS_EXCEPTION);
return errorPayload;
}

@Override
public Publisher<Void> metadataPush(Payload payload) {
return subscriber -> subscriber.onError(NO_AVAILABLE_RS_EXCEPTION);
return errorVoid;
}

@Override
Expand Down
17 changes: 0 additions & 17 deletions reactivesocket-core/src/main/java/io/reactivesocket/DefaultReactiveSocket.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,23 +478,6 @@ public void shutdown() {
}
}

private static <T> Publisher<T> error(Throwable e) {
return (Subscriber<? super T> s) -> {
s.onSubscribe(new Subscription() {
@Override
public void request(long n) {
// should probably worry about n==0
s.onError(e);
}

@Override
public void cancel() {
// ignoring just because
}
});
};
}

public String toString() {
return "duplexConnection=[" + this.connection + "]";
}
Expand Down