-
Notifications
You must be signed in to change notification settings - Fork 140
Drop ColorPrinter's workaround for BasicObject #1051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a708d6a to
f267df3
Compare
|
Update: Updating rubygems on CI resolves the issue. Based on the debugging run's message: It looks like Ruby 2.7's bundler failed to use the |
a982abd to
7d99694
Compare
`pp` 0.6.0+ includes ruby/pp#26 to handle BasicObject, so we can drop the workaround.
7d99694 to
1dc176c
Compare
|
|
||
| spec.add_dependency "reline", ">= 0.4.2" | ||
| spec.add_dependency "rdoc", ">= 4.0.0" | ||
| spec.add_dependency "pp", ">= 0.6.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to specify this instead of adding it just to Gemfile for testing?
User can install bug fixed version of pp if they want (but I know user usually don't update pp nor add pp to Gemfile)
It is beneficial, but adding it is not a usual case. We don't usually bump reline or rdoc requirements for each bug fixes.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to specify it otherwise with the workaround removed, users with newer IRB but older pp will get a regression when dealing with basic objects.
It is beneficial, but adding it is not a usual case. We don't usually bump reline or rdoc requirements for each bug fixes.
We do when we have to make corresponding changes on IRB side?
It's like when repl_type_completor adopts new Prism APIs/structures, it bumps its requirement for prism.
We can of course make the patch conditional based on the version of pp it uses, but IMO with the size of the current patch it's not worth it.
(ruby/irb#1051) `pp` 0.6.0+ includes ruby/pp#26 to handle BasicObject, so we can drop the workaround. ruby/irb@08908d43c7
pp0.6.0+ includes ruby/pp#26 to handle BasicObject, so we can drop the workaround.(
ppsupports Ruby 2.7+ too)