Handle BasicObject #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now attempting to pretty print a BasicObject or any other
object lacking a few core Object methods will result in an error
```
Error: test_basic_object(PPTestModule::PPInspectTest): NoMethodError: undefined method `is_a?' for an instance of BasicObject
lib/pp.rb:192:in `pp'
lib/pp.rb:97:in `block in pp'
lib/pp.rb:158:in `guard_inspect_key'
lib/pp.rb:97:in `pp'
test/test_pp.rb:131:in `test_basic_object'
128:
129: def test_basic_object
130: a = BasicObject.new
=> 131: assert_match(/\A#<BasicObject:0x[\da-f]+>\n\z/, PP.pp(a, ''.dup))
132: end
133: end
134:
```
With some fairly small changes we can fallback to `Object#inspect`
which is better than an error.
hsbt
approved these changes
Nov 12, 2024
Closed
st0012
added a commit
to ruby/irb
that referenced
this pull request
Dec 18, 2024
`pp` 0.6.0+ includes ruby/pp#26 to handle BasicObject, so we can drop the workaround.
st0012
added a commit
to ruby/irb
that referenced
this pull request
Jan 11, 2025
`pp` 0.6.0+ includes ruby/pp#26 to handle BasicObject, so we can drop the workaround.
st0012
added a commit
to ruby/irb
that referenced
this pull request
Jan 11, 2025
`pp` 0.6.0+ includes ruby/pp#26 to handle BasicObject, so we can drop the workaround.
tompng
pushed a commit
to ruby/irb
that referenced
this pull request
Jan 12, 2025
`pp` 0.6.0+ includes ruby/pp#26 to handle BasicObject, so we can drop the workaround.
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jan 12, 2025
(ruby/irb#1051) `pp` 0.6.0+ includes ruby/pp#26 to handle BasicObject, so we can drop the workaround. ruby/irb@08908d43c7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now attempting to pretty print a BasicObject or any other object lacking a few core Object methods will result in an error
With some fairly small changes we can fallback to
Object#inspectwhich is better than an error.