Publish RBS #20
Merged
Publish RBS #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as ruby/prime#28 .
Current
Currently, when a user does a rbs collection install, mutex_m uses the type definition of ruby/rbs.
mutex_m has a history of copying the sig directory from ruby/rbs (#15), but does not include the sig directory in the gem package.
rbs searches for the type definition of mutex_m in the order of gem package -> rbs repository -> gem_rbs_collection, and uses the type definition of rbs repository found.
Change
Include the files in the sig directory in the gem package to give preference to type definitions in this repository.
Notice
The scenarios where the signatures from this repository reach users are quite limited.
This is because the issue lies on the ruby/rbs side.
To ensure users can access the repository's signatures, two issues need to be resolved.
This PR solves one of them. I also plan to fix the issue with ruby/rbs.