Skip to content

Conversation

@ksss
Copy link
Contributor

@ksss ksss commented Nov 18, 2024

Current

Currently, when a user does a rbs collection install, prime uses the type definition of gem_rbs_collection.
prime has a history of copying the sig directory from gem_rbs_collection (link), but does not include the sig directory in the gem package.
rbs searches for the type definition of prime in the order of gem package -> rbs repository -> gem_rbs_collection, and uses the type definition of gem_rbs_collection found last.

Change

Include the files in the sig directory in the gem package to give preference to type definitions in this repository.

Confirmation

  1. Apply this change.
  2. Run in this repo.
$ bundle exec rake build install
  1. Add prime at Gemfile in other repo.
  2. Call bundle exec rbs collection install/update in other repo.
  3. Check prime in rbs_collection.lock.yaml.
- name: prime
  version: 0.1.2
  source:
    type: rubygems

@hsbt hsbt merged commit 764192c into ruby:master Nov 19, 2024
@ksss ksss deleted the publish-rbs branch November 19, 2024 05:07
@ksss ksss mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants