Skip to content

Conversation

@hanachin
Copy link
Contributor

irb(main):001:0> 42.instance_eval { p _1 }
42
=> 42
irb(main):002:-> 42.instance_eval(&->{})
Traceback (most recent call last):
        6: from /usr/local/var/rbenv/versions/master/bin/irb:23:in `<main>'
        5: from /usr/local/var/rbenv/versions/master/bin/irb:23:in `load'
        4: from /usr/local/var/rbenv/versions/master/lib/ruby/gems/2.7.0/gems/irb-1.1.0.pre.3/exe/irb:11:in `<top (required)>'
        3: from (irb):2
        2: from (irb):2:in `instance_eval'
        1: from (irb):2:in `block in irb_binding'
ArgumentError (wrong number of arguments (given 1, expected 0))

@soutaro
Copy link
Member

soutaro commented Oct 24, 2019

I will check what is happening...

@soutaro
Copy link
Member

soutaro commented Oct 24, 2019

Okay, it is because BasicObject does not provide some important methods like method, class, or singleton_class. I think skip writing tests for BasicObject would make sense.

@soutaro soutaro mentioned this pull request Oct 24, 2019
@hanachin hanachin marked this pull request as ready for review October 25, 2019 00:51
@hanachin hanachin force-pushed the fix_basic_object_instance_eval_signature branch from 0e4aa52 to 6d3864a Compare October 26, 2019 03:15
```
irb(main):001:0> 42.instance_eval { p _1 }
42
=> 42
irb(main):002:-> 42.instance_eval(&->{})
Traceback (most recent call last):
        6: from /usr/local/var/rbenv/versions/master/bin/irb:23:in `<main>'
        5: from /usr/local/var/rbenv/versions/master/bin/irb:23:in `load'
        4: from /usr/local/var/rbenv/versions/master/lib/ruby/gems/2.7.0/gems/irb-1.1.0.pre.3/exe/irb:11:in `<top (required)>'
        3: from (irb):2
        2: from (irb):2:in `instance_eval'
        1: from (irb):2:in `block in irb_binding'
ArgumentError (wrong number of arguments (given 1, expected 0))
```
@hanachin hanachin force-pushed the fix_basic_object_instance_eval_signature branch from 6d3864a to 3fe474d Compare October 26, 2019 03:16
@hanachin
Copy link
Contributor Author

#41 made BasicObject testable 👏 so I added a test ✌️

@soutaro soutaro merged commit 3c78eca into ruby:master Oct 27, 2019
@hanachin hanachin deleted the fix_basic_object_instance_eval_signature branch December 29, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants