Skip to content

Conversation

@soutaro
Copy link
Member

@soutaro soutaro commented Oct 24, 2019

#39 told me that BasicObject does not have several methods including method, class, or singleton_class. So, we should extract these methods beforehand.

The patch includes a fix to extract is_a? from Kernel, not Object. And it adds PP for future printf debugging.

@hanachin
Copy link
Contributor

hanachin commented Oct 25, 2019

@soutaro
Copy link
Member Author

soutaro commented Oct 25, 2019

@hanachin No #inspect ... 😱 Thanks.

Copy link
Contributor

@hanachin hanachin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 🌾

@soutaro soutaro merged commit 21f4608 into master Oct 25, 2019
@soutaro soutaro deleted the methods branch October 25, 2019 07:04
soutaro pushed a commit that referenced this pull request May 2, 2025
`rbs_node_destroy`, `rbs_hash_free`, `rbs_node_list_free` are only
calling each other recursively without any real freeing logic.

This is the result of previous efforts to allocate all nodes on the
arena. So we don't need these functions anymore.

Discovered while working on #41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants