Skip to content

Minor cleanup and optimization #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
headius merged 10 commits into from
Oct 10, 2023
Merged

Minor cleanup and optimization #67

headius merged 10 commits into from
Oct 10, 2023

Conversation

@headius
Copy link
Contributor

@headius headius commented Oct 10, 2023

A few minor tweaks.

  • Cache field accesss throughout
  • Arity-split values_at method for low arity calls
  • General cleanup

headius added 10 commits October 10, 2023 14:03
@headius
Arity-split values_at
5e86907 
All methods now have specific-arity paths up to 3 arguments.
@headius
Remove long-deprecated forms
c332c47
@headius
Clean up imports
672891e
@headius
Clean up doco
3b581e4
@headius
Just use a boolean for the sole flag we support
0063347
@headius
Dead code
17d2572
@headius
Avoid retrieving values repeatedly
261e81a
@headius
Use getClassFromPath to do it all at once
d6826fa
@headius
Whitespace
1804c95
@headius
Use JRuby 9.4.1.0 for CI due to region changes
5aae8bf 
The Region changes in JRuby's regex engine require that we support
both the old and new API for a while. Unfortunately the only
version of JRuby that contains both APIs is 9.4.1.0 so we have to
at least build against that version. Testing can occur against
any version, but for now this is the simplest way to get CI green.
@headius headius merged commit 00e0982 into ruby:master Oct 10, 2023
@headius headius deleted the minor_optz branch October 10, 2023 19:43
@headius
Copy link
Contributor Author

headius commented Oct 10, 2023

@mrkn Could we do a release soon? These are small changes but also minor perf improvements and good cleanup.

@kou
Copy link
Member

kou commented Oct 11, 2023

I can do it.

@kou
Copy link
Member

kou commented Oct 11, 2023

Done.

headius added a commit to headius/jruby that referenced this pull request Oct 19, 2023
@headius
Update strscan to 3.0.7
11eb8e1 
See ruby/strscan#67
@headius headius mentioned this pull request Oct 19, 2023
Merged
headius added a commit to headius/jruby that referenced this pull request Jan 21, 2024
@headius
Update strscan to 3.0.9
d2502e0 
Patches:

* ruby/strscan#67
* ruby/strscan#79
* ruby/strscan#81
* ruby/strscan#84
@headius headius mentioned this pull request Jan 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@headius @kou