Skip to content

Use str encoding for empty rest string #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
headius merged 1 commit into from
Jan 14, 2024
Merged

Use str encoding for empty rest string #79

headius merged 1 commit into from
Jan 14, 2024

Conversation

@headius
Copy link
Contributor

@headius headius commented Jan 14, 2024

The empty string here should match the encoding of the scanner string.

Fixes #78

@headius
Copy link
Contributor Author

headius commented Jan 14, 2024

The tests added by #80 pass with this PR. Merging.

@headius headius merged commit 124cb7f into ruby:master Jan 14, 2024
@headius headius deleted the match_encoding_for_empty_rest branch January 14, 2024 11:21
This was referenced Jan 14, 2024
Merged
Closed
headius added a commit to headius/jruby that referenced this pull request Jan 21, 2024
@headius
Update strscan to 3.0.9
d2502e0 
Patches:

* ruby/strscan#67
* ruby/strscan#79
* ruby/strscan#81
* ruby/strscan#84
@headius headius mentioned this pull request Jan 21, 2024
Merged
@naitoh naitoh mentioned this pull request May 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

In JRuby, StringScanner.new("") can only hold Encoding:US-ASCII encoding.

1 participant

@headius