add test for Facilitators submitting a workshop idea#612
Merged
maebeale merged 5 commits intorubyforgood:mainfrom Jan 5, 2026
Merged
add test for Facilitators submitting a workshop idea#612maebeale merged 5 commits intorubyforgood:mainfrom
maebeale merged 5 commits intorubyforgood:mainfrom
Conversation
maebeale
reviewed
Jan 4, 2026
| describe "Navigate to Workshop Idea page" do | ||
| context "When Facilitator is logged in" do | ||
| before do | ||
| create(:windows_type, :adult) |
Collaborator
There was a problem hiding this comment.
@diti0-dot we used to have to do this bc of a callback dependency, but we've removed that, so your tests should still pass even if you remove these create(:windows_type) statements
maebeale
approved these changes
Jan 4, 2026
Collaborator
maebeale
left a comment
maebeale
left a comment
There was a problem hiding this comment.
This is great @diti0-dot !!!
It's probably worth a follow-up in another PR to add some additional tests for the non-happy-path that ensure the required fields show validation errors when missing (or when wrong file type in the case of the attachments).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
Adds system tests for workshop idea submission flow. Tests form access, submission, and cancellation.
How did you approach the change?
Followed existing test patterns using FactoryBot for data.
Anything else to add?
First time writing tests - feedback welcome! Happy New Year!🎉🥳