ci: Add codeowners file to finch#501
Merged
Merged
Conversation
Signed-off-by: Vishwas Siravara <siravara@amazon.com>
austinvazquez
approved these changes
Jul 25, 2023
KevinLiAWS
approved these changes
Jul 25, 2023
Contributor
|
Hey, sorry for getting to this a bit late, but you will also need to add the opposite entry to ci-docs.yaml, or else our PRs will get blocked (as they require those tests to be run, but have no way to run them). |
Contributor
Author
:( had forgotten about this strangeness. Created PR for it. Good thing though, the CODEOWNERS check worked. Created PR to fix it. #502 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A.
Description of changes:
CODEOWNERSfile to finch to ensure that release-please PR which modifiesCHANGELOG.mdhas to be reviewed and approved by a member of@runfinch/dev-teamin order to kick off a finch release..githubdirectory requires approval from@runfinch/dev-team, i.e even modifications toCODEOWNERSwould require an approval from the team.ci.yamlto not run CI checks onCODEOWNERSfile.Testing done:
Yes, on personal repo.
See code owners setting in CODEOWNERS and test requesting review from code owner
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.