Update release-please.yml#22
Open
vsiravar wants to merge 1 commit into
Open
Conversation
1 task
vsiravar
added a commit
to runfinch/finch
that referenced
this pull request
Jul 25, 2023
Issue #, if available: N/A. *Description of changes:* - Add `CODEOWNERS` file to finch to ensure that [release-please PR](#483) which modifies` CHANGELOG.md` has to be reviewed and approved by a member of `@runfinch/dev-team` in order to kick off a finch release. - Ensures that any changes to `.github` directory requires approval from `@runfinch/dev-team`, i.e even modifications to `CODEOWNERS` would require an approval from the team. - Modifies `ci.yaml` to not run CI checks on `CODEOWNERS` file. *Testing done:* Yes, on personal repo. See code owners setting in [CODEOWNERS](https://github.com/vsiravar/github-actions-experiments/blob/main/.github/CODEOWNERS) and test [requesting review from code owner](vsiravar/github-actions-experiments#22) - [X] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Vishwas Siravara <siravara@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
code-owners test