ci: add script to update rootfs URL#507
Conversation
for Finch on Windows runfinch#492, we need to provide a rootfs to WSL2. This rootfs lives in our dependencies bucket, and will be updated from time-to-time for security patches, bug fixes, etc. This commit will automatically pull the most recent rootfs from the depenedencies bucket as part of the Update Deps action. Signed-off-by: Gavin Inglis <giinglis@amazon.com>
| - name: update dependencies url | ||
| run: | | ||
| ./.github/bin/update-lima-dep.sh -d ${{ secrets.DEPENDENCY_BUCKET_NAME }} -a {{ secrets.ARTIFACT_BUCKET_NAME }} | ||
| ./.github/bin/update-rootfs.sh -d ${{ secrets.DEPENDENCY_BUCKET_NAME }} |
There was a problem hiding this comment.
Can we have a different bucket/sub-folder for the new artifact?
There was a problem hiding this comment.
sure, or how about under respective ${ARCH} folder as lima/qemu is today?
Line 38 in 81d8b20
There was a problem hiding this comment.
I think a folder at the same level with aarch64 and amd64 maybe better so that each type of the artifact won't be stored in the same folder which will be cleaner and reduce the risk for artifact remove case for a dir.
There was a problem hiding this comment.
By the way, I think we may only need this change in the Core repo
There was a problem hiding this comment.
By the way, I think we may only need this change in the Core repo
Yea thanks for pointing that out... There are a couple places where we can deduplicate code / actions between finch and finch-core. Opened #508 to track
|
Closing in favor of runfinch/finch-core#131 and #511 |
3 participants
Issue #, if available: #492
Description of changes:
for Finch on Windows #492, we need to provide a rootfs to WSL2. This rootfs lives in our dependencies bucket, and will be updated from time-to-time for security patches, bug fixes, etc. This commit will automatically pull the most recent rootfs from the dependencies bucket as part of the update deps action.
TODO: similar change to finch-core.
Testing done:
locally run script with
FINCH_ROOTFS_URL ?= https://deps.runfinch.com/finch-rootfs-production-amd64-000000000.tar.zstset in Makefile, observe update.License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.