ci: remove duplicate actions, use finch-core#511
Merged
ginglis13 merged 1 commit intorunfinch:mainfrom Aug 1, 2023
Merged
Conversation
1 task
pendo324
previously approved these changes
Jul 31, 2023
Contributor
pendo324
left a comment
pendo324
left a comment
There was a problem hiding this comment.
Nice, now we don't have to maintain this in multiple places
vsiravar
previously approved these changes
Jul 31, 2023
finch-core already defines scripts for updating some dependencies. Since this repo takes finch-core as a submodule, some actions can be consolidated to this one for dependency updates. CORE_URL is unused and that behavior is removed. Signed-off-by: Gavin Inglis <giinglis@amazon.com>
ginglis13
force-pushed
the
use-submodule-update-deps
branch
from
bdfb742 to
d8639ad
Compare
1 task
ginglis13
added a commit
that referenced
this pull request
Aug 4, 2023
Issue #, if available: *Description of changes:* #511 removed the duplicate action in finch/finch-core for updating deps; however, now need AWS creds in this action for the dependency updates. *Testing done:* - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Gavin Inglis <giinglis@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
finch-core already defines scripts for updating some dependencies:
https://github.com/runfinch/finch-core/blob/main/bin/update-deps.sh
Since this repo takes finch-core as a submodule, some actions can be consolidated to this one for dependency updates.
CORE_URL is unused and that behavior is removed.
Issue #, if available:
Description of changes:
Testing done:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.