feat: extract shared object detail fields and fix ResourcePicker height#204
Merged
feat: extract shared object detail fields and fix ResourcePicker height#204
Conversation
This was referenced Apr 16, 2026
…ht clipping - Extract buildObjectDetailFields() into objectService.ts as shared utility - Refactor ObjectDetailScreen to use shared utility, reducing code duplication - Add additionalOverhead prop to ResourcePicker for tabbed wrapper height calculation - Add objectService tests (14 tests) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jason-rl
force-pushed
the
jc/object-detail-refactor
branch
from
e054fd3 to
7dc281a
Compare
…elds Add color field to ObjectDetailField for semantic coloring (error/warning) on expiry values. Use formatTimestamp for Created field to include relative time. Map color names to theme values in ObjectDetailScreen. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dines-rl
approved these changes
Apr 23, 2026
jrvb-rl
pushed a commit
that referenced
this pull request
Apr 23, 2026
🤖 I have created a release *beep* *boop* --- ## [1.16.0](v1.15.0...v1.16.0) (2026-04-23) ### Features * add agent/axon TUI screens and align list commands with pagination ([#205](#205)) ([1481d7a](1481d7a)) * add secret config to bmj, toggle available to show public benchmarks for new jobs ([#156](#156)) ([86cda21](86cda21)) * better handling of RUNLOOP_BASE_URL ([#216](#216)) ([f4b59fd](f4b59fd)) * extract shared object detail fields and fix ResourcePicker height ([#204](#204)) ([b685b65](b685b65)) * improve agent support in interactive rli ([#209](#209)) ([4aa5ca6](4aa5ca6)) * update agents support in rli command line ([#200](#200)) ([512d41f](512d41f)) ### Bug Fixes * "Showing 1-0 of 0" in TUI, cache unfiltered total count through search reset ([#196](#196)) ([8170888](8170888)) * don't reset settings TUI menu cursor on back ([#198](#198)) ([7a0796d](7a0796d)) * harden dependency security posture ([#211](#211)) ([198ad1e](198ad1e)) * improve column width handling for rli agent list ([#199](#199)) ([d4aa73f](d4aa73f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
pnpm buildpasses🤖 Generated with Claude Code