feat: improve agent support in interactive rli by jrvb-rl · Pull Request #209 · runloopai/rl-cli

jrvb-rl · 2026-04-16T15:31:28Z

This PR adapts and modifies the changes from Jason's jason/agents_tab branch. There are a number of additions to the interactive rli interface:

New Agents screens: Add agent list (with private/public tabs), detail, and create screens to the interactive rli TUI, accessible from the main menu via [a] shortcut
Unified agent column definitions: Extract shared getAgentColumns() in agentService and buildAgentTableColumns() in a new agentColumns.ts module, used by both the CLI rli agent list and all
interactive agent pickers (agent list, devbox create, benchmark job create) for consistent column layout (NAME, SOURCE, VERSION, ID, CREATED) with terminal-width-adaptive sizing
Agent picker in devbox create: Add optional agent mount field to the devbox creation form with a tabbed private/public agent picker that merges results during search
Agent picker in benchmark job create: Wire up agent selection using the shared columns, with server-side search and correct totalCount propagation
ResourcePicker improvements: Add extraDeps and extraOverhead props for tab-switching contexts; add nextCursor support for opaque/merged pagination cursors; stabilize checkbox column
rendering via ref to reduce flicker; fix cross-page multi-select by tracking item objects in a ref Map
CLI agent list cleanup: Remove local ColumnDef/computeColumnWidths() in favor of shared getAgentColumns(); fix scoped package version styling (lastIndexOf("@"))
Routing & navigation: Register agent-list, agent-detail, agent-create screens in Router with proper cleanup; add Agents to main menu and benchmark menu label updates

Files changed

src/services/agentService.ts
Add AgentColumn, agentVersionText(), getAgentColumns(); fix totalCount to use response.total_count

src/components/agentColumns.ts
New — shared buildAgentTableColumns() UI-layer column builder

src/commands/agent/list.ts
Replace local column/width logic with shared getAgentColumns()

src/screens/AgentListScreen.tsx
New — agent list with private/public tabs

src/screens/AgentDetailScreen.tsx
New — agent detail with delete operation

src/screens/AgentCreateScreen.tsx
New — agent creation form (npm/pip/git/object sources)

src/components/MainMenu.tsx
Add Agents menu item with [a] shortcut

src/components/BenchmarkMenu.tsx
Rename menu labels for clarity

src/router/Router.tsx
Register 3 new agent screens

src/store/navigationStore.tsx
Add agent screen types

src/screens/MenuScreen.tsx
Route "agents" selection to agent-list

src/components/DevboxCreatePage.tsx
Add agent mount picker with merged private+public search

src/screens/BenchmarkJobCreateScreen.tsx
Switch agent picker to single-select, use shared columns, server-side search

src/components/ResourcePicker.tsx
Add extraDeps, extraOverhead, nextCursor; stabilize columns via ref; fix cross-page selection tracking

src/hooks/useCursorPagination.ts
Support opaque nextCursor in fetch results

fix list display fix list view refactor to consolidate shared rendering code remove dead agentStore code adjust labels remove multi selection for benchmark job agents. UX was too ugly so simplifying for now

jason-rl · 2026-04-16T15:41:24Z

Comparisons between this PR and several of my PRs

Change in #209	Overlap?
New Agents screens (list with private/public tabs, detail, create)	✅ #205 — agent detail screen; #206 — agent list/picker with private/public tabs in devbox create. Agent create screen and standalone agent list screen are unique to #209.
Unified agent column definitions (`getAgentColumns()`, `buildAgentTableColumns()`)	✅ #205 — we aligned `agent list` CLI with standard pagination/output pattern. The shared column extraction approach is unique to #209.
Agent picker in devbox create (mount field, tabbed private/public picker, merged search)	✅ #206 — agent mount picker with private/public tabs, merged search, grayed-out conflicting agents, inline path editing. Very heavy overlap.
Agent picker in benchmark job create	❌ Unique to #209
ResourcePicker improvements (extraDeps, extraOverhead, nextCursor, stabilize checkbox, fix cross-page multi-select)	⚠️ Partially overlaps #204 (ResourcePicker height fix) and #206 (ResourcePicker changes for agent/object pickers). The specific improvements (extraDeps, extraOverhead, nextCursor, checkbox stabilization) are mostly unique to #209.
CLI agent list cleanup (shared columns, scoped package version styling fix)	✅ #205 — aligned `agent list` CLI with standard pagination. The `lastIndexOf("@")` fix is unique to #209.
Routing & navigation (register agent screens, main menu [a] shortcut)	✅ #205 — registers agent-detail screen and routing. #209 adds agent-list and agent-create screens which are unique.

Summary: The agent picker in devbox create (#206) and agent detail/routing (#205) have the heaviest overlap. The benchmark job agent picker, agent create screen, standalone agent list screen, shared column extraction, and several ResourcePicker improvements are unique to #209.

james-rl

a few issues:

I think the first one is the only big one; the rest are nice to haves.

The AgentCreateScreen leaves the success screen non-interactive.
On success, creating is never reset to false, but input handling is disabled whenever creating is true. That means the screen tells the user to press Enter/Esc, but those keys no longer work after a successful create.
We only seem to let you pick one agent in interactive mode -- is that intentional? It looks like this was changed
CLI agent list can overflow and misalign on narrow terminals or long values.
getAgentColumns() forces a minimum flexible width even when the terminal is too narrow, and the CLI renderer pads but never truncates. So the computed table can exceed the terminal width, and long IDs/versions can push later columns out of alignment.

james-rl · 2026-04-16T18:04:25Z

+          type: "agent_mount",
+          agent_id: formData.agent_id,
+          agent_name: null,
+        } as any);


this as any looks a bit fishy to me

Also, why pass agent_name as null if you're using agent_id instead of undefined?

This could be a backend api schema issue

james-rl · 2026-04-16T18:10:23Z

+          }}
+          onSelect={handleAgentSelect}
+          onCancel={() => setShowAgentPicker(false)}
+          initialSelected={formData.agent_id ? [formData.agent_id] : []}


I think this will do incorrect things if you toggle between public and private tabs

james-rl · 2026-04-16T18:13:38Z

+                      const publicResult = await listPublicAgents({
+                        limit: remainingSlots,
+                        startingAfter: publicCursor,
+                        search: params.search,
+                      });
+
+                      const uniquePublic = publicResult.agents.filter(
+                        (a) => !privateIds.has(a.id),
+                      );
+                      publicAgentsConsumed = uniquePublic.slice(
+                        0,
+                        remainingSlots,
+                      );
+                      publicHasMore =
+                        publicResult.hasMore ||
+                        uniquePublic.length > remainingSlots;


publicResult has a limit of remainingSlots so the second condition is never true

james-rl · 2026-04-16T18:31:05Z

+  const [activeTab, setActiveTab] = React.useState<Tab>("private");
+  const [selectedIndex, setSelectedIndex] = React.useState(0);
+
+  useExitOnCtrlC();


we should probably register a global hook for sig int

jrvb-rl · 2026-04-16T22:42:09Z

Thanks for the detailed review!!

a few issues:

I think the first one is the only big one; the rest are nice to haves.

The AgentCreateScreen leaves the success screen non-interactive.
On success, creating is never reset to false, but input handling is disabled whenever creating is true. That means the screen tells the user to press Enter/Esc, but those keys no longer work after a successful create.

Yes, good catch! This was working earlier, but I must have stomped on it at some point without realizing. Thanks for the fix!

We only seem to let you pick one agent in interactive mode -- is that intentional? It looks like this was changed

Yes, that was intentional. Maintaining the state cleanly across different trips into/out of the agent picker was messy and I had some edge cases that I couldn't get to work properly. Rather than burn more time on it yesterday, I opted to simplify and go for the single-agent selection in the TUI. Since the CLI still allows multiple agents, users can still do the things they need that way. (And the CLI is probably the more useful path anyway...)

CLI agent list can overflow and misalign on narrow terminals or long values.
getAgentColumns() forces a minimum flexible width even when the terminal is too narrow, and the CLI renderer pads but never truncates. So the computed table can exceed the terminal width, and long IDs/versions can push later columns out of alignment.

Good point. I think wrapping is inevitable if the information is too long to fit, but I changed the CLI version to make sure the columns line up in all cases.

…ion (#205) ## Summary - Add agent list/detail TUI screens with private/public tabs, actions popup, delete confirmation, and full cursor pagination - Add axon list and axon detail TUI screens - Rewrite CLI `agent list` and `axon list` to `.tsx` with TUI components and standard pagination (`--limit`/`--starting-after`) - Add `includeTotalCount` parameter to agent service for accurate pagination totals - Add axon service enhancements: search, `getAxon()`, `totalCount` - Group Agents, Objects, and Axons under new "Agents & Objects" main menu submenu - Move Benchmarks menu item before Settings - Rename "Storage Objects" to "Objects" throughout TUI (breadcrumbs, labels, table titles) Note: Agent routing, navigation store types, and `getAgentColumns()`/`buildAgentTableColumns()` were introduced by #209 and are not part of this PR's diff. ## Test plan - [x] `pnpm build` passes - [x] Tests pass - [x] Command docs auto-generated 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

🤖 I have created a release *beep* *boop* --- ## [1.16.0](v1.15.0...v1.16.0) (2026-04-23) ### Features * add agent/axon TUI screens and align list commands with pagination ([#205](#205)) ([1481d7a](1481d7a)) * add secret config to bmj, toggle available to show public benchmarks for new jobs ([#156](#156)) ([86cda21](86cda21)) * better handling of RUNLOOP_BASE_URL ([#216](#216)) ([f4b59fd](f4b59fd)) * extract shared object detail fields and fix ResourcePicker height ([#204](#204)) ([b685b65](b685b65)) * improve agent support in interactive rli ([#209](#209)) ([4aa5ca6](4aa5ca6)) * update agents support in rli command line ([#200](#200)) ([512d41f](512d41f)) ### Bug Fixes * "Showing 1-0 of 0" in TUI, cache unfiltered total count through search reset ([#196](#196)) ([8170888](8170888)) * don't reset settings TUI menu cursor on back ([#198](#198)) ([7a0796d](7a0796d)) * harden dependency security posture ([#211](#211)) ([198ad1e](198ad1e)) * improve column width handling for rli agent list ([#199](#199)) ([d4aa73f](d4aa73f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

jrvb-rl added 2 commits April 16, 2026 03:16

Agents tab, private + public agents

50bfcef

fix list display fix list view refactor to consolidate shared rendering code remove dead agentStore code adjust labels remove multi selection for benchmark job agents. UX was too ugly so simplifying for now

fmt

5518903

jrvb-rl requested review from james-rl and jason-rl April 16, 2026 15:31

jrvb-rl changed the title ~~Improve agent support in interactive rli~~ feat: improve agent support in interactive rli Apr 16, 2026

jrvb-rl requested a review from tode-rl April 16, 2026 18:25

james-rl approved these changes Apr 16, 2026

View reviewed changes

switch to more standard way of entering deets in create agent page

7f40bf6

jrvb-rl added 4 commits April 16, 2026 15:48

fix agent column widths

9f5a8b3

address comments

19cd8c9

remove unused merged view code

3d5dc5c

fmt

97c70c5

jrvb-rl merged commit 4aa5ca6 into main Apr 17, 2026
16 checks passed

jrvb-rl deleted the jrvb/rli-agent-additions branch April 17, 2026 19:17

github-actions Bot mentioned this pull request Apr 15, 2026

chore(main): release 1.16.0 #197

Merged

This was referenced Apr 21, 2026

feat: add agent/axon TUI screens and align list commands with pagination #205

Merged

feat: multi-agent mount support with validation #206

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: improve agent support in interactive rli#209

feat: improve agent support in interactive rli#209
jrvb-rl merged 7 commits intomainfrom
jrvb/rli-agent-additions

jrvb-rl commented Apr 16, 2026

Uh oh!

jason-rl commented Apr 16, 2026 •

edited

Loading

Uh oh!

james-rl left a comment

Uh oh!

james-rl Apr 16, 2026

Uh oh!

james-rl Apr 16, 2026

Uh oh!

james-rl Apr 16, 2026

Uh oh!

james-rl Apr 16, 2026

Uh oh!

jrvb-rl commented Apr 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jrvb-rl commented Apr 16, 2026

Files changed

Uh oh!

jason-rl commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

james-rl left a comment

Choose a reason for hiding this comment

Uh oh!

james-rl Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

james-rl Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

james-rl Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

james-rl Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

jrvb-rl commented Apr 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jason-rl commented Apr 16, 2026 •

edited

Loading