Skip to content

Release tracking PR: electrsd 0.38.1#571

Open
tcharding wants to merge 2 commits intorust-bitcoin:masterfrom
tcharding:push-mwltplmkuoml
Open

Release tracking PR: electrsd 0.38.1#571
tcharding wants to merge 2 commits intorust-bitcoin:masterfrom
tcharding:push-mwltplmkuoml

Conversation

@tcharding
Copy link
Copy Markdown
Member

@tcharding tcharding commented Apr 29, 2026

We released a typo in the electrsd manifest. Requires release to push the changes to crates.io

Fix the typo, bump the version number, and add a changelog entry.

Copy link
Copy Markdown
Collaborator

@jamillambert jamillambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c526f94

@tcharding
Copy link
Copy Markdown
Member Author

Forgot to actually add the changelog entry.

Comment thread electrsd/CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
# 0.38.0 - 2026-04-29
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# 0.38.0 - 2026-04-29
# 0.38.1 - 2026-04-29

Who knew correcting a typo would take so many revisions.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, goodness me.

@satsfy
Copy link
Copy Markdown
Contributor

satsfy commented Apr 30, 2026

@tcharding you may also like to consider modifying this in electrsd/Cargo.toml.

bitcoind_23_1 = ["bitcoind/23_2"]

A recent change was made with what seems to be the wrong feature for bitcoind. I suppose it should be 23_2 because that is the flag name in bitcoind. So it should become:

bitcoind_23_2 = ["bitcoind/23_2"]

I opened this PR for that fix.

tcharding added 2 commits May 1, 2026 09:58
The documented way to depend on this crate is stale, fix it.
Requires release to push the changes to crates.io

Fix the typo, bump the version number, and add a changelog entry.
@tcharding
Copy link
Copy Markdown
Member Author

tcharding commented May 1, 2026

So you guys know whats in my mind. I rekon we can merge this, do point release, then merge #573 and do another major release (0.39.0). And we could get #570 in before doing 0.39.0.

@satsfy
Copy link
Copy Markdown
Contributor

satsfy commented May 1, 2026

Should this, too, be part of the present release? #574

@tcharding
Copy link
Copy Markdown
Member Author

This PR is only for releasing electrsd so #574 is unrelated. We could definitely merge it and do a point release of bitcoind if you want to hack up the release tracking PR for it. If you do choose to do that just copy what is here please (including title format etc). I don't mind if it gets done or not.

Copy link
Copy Markdown
Collaborator

@jamillambert jamillambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6423a8a

Copy link
Copy Markdown
Contributor

@satsfy satsfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6423a8a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants