Skip to content

electrsd: fix bitcoind 23_2 feature version#573

Open
satsfy wants to merge 1 commit intorust-bitcoin:masterfrom
satsfy:fix-23_1-feature
Open

electrsd: fix bitcoind 23_2 feature version#573
satsfy wants to merge 1 commit intorust-bitcoin:masterfrom
satsfy:fix-23_1-feature

Conversation

@satsfy
Copy link
Copy Markdown
Contributor

@satsfy satsfy commented Apr 30, 2026

Seems that bitcoind feature version name should have been 23_2 because that's what shows up in bitcoind.

@satsfy
Copy link
Copy Markdown
Contributor Author

satsfy commented Apr 30, 2026

Also, I see in electrsd/README.md that it suggests for the user to write the following:

electrsd = { version= "0.23", features = ["corepc-node_23_1", "electrs_0_9_1"] }

Is this 23_1 correct? I'm not sure so I didn't include in this PR.

@tcharding
Copy link
Copy Markdown
Member

Also, I see in electrsd/README.md that it suggests for the user to write the following:

electrsd = { version= "0.23", features = ["corepc-node_23_1", "electrs_0_9_1"] }

Is this 23_1 correct? I'm not sure so I didn't include in this PR.

Ah that is totally stale. Should be bitcoind_23_2

@tcharding
Copy link
Copy Markdown
Member

Turns out my shell alias for grepping repos was to restrictive and there are a bunch of mentions of corepc-node still in various READMEs (my mistake from #542).

Can you do a separate PR that fixes all those please? Then this one can go in on top of that, and then we can point release any crates that got changed.

@tcharding
Copy link
Copy Markdown
Member

FWIW this changes is correct but means we have to do a major release not a point release.

@tcharding
Copy link
Copy Markdown
Member

I did the electrs readme fix already in #571

@jamillambert
Copy link
Copy Markdown
Collaborator

Turns out my shell alias for grepping repos was to restrictive and there are a bunch of mentions of corepc-node still in various READMEs (my mistake from #542).

I looked at this too when reviewing that PR, and I didn't understand how I missed them so I looked again. I think it's because there are 1622 occurrences of "node" on master, so we had to be more specific, and the "corepc-node" that need to be changed are not in "bitcoind/".

Good catch though.

Copy link
Copy Markdown
Collaborator

@jamillambert jamillambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ba1d7d9

Should wait for #574 before cutting a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants