electrsd: fix bitcoind 23_2 feature version#573
electrsd: fix bitcoind 23_2 feature version#573satsfy wants to merge 1 commit intorust-bitcoin:masterfrom
Conversation
|
Also, I see in electrsd/README.md that it suggests for the user to write the following: electrsd = { version= "0.23", features = ["corepc-node_23_1", "electrs_0_9_1"] }Is this 23_1 correct? I'm not sure so I didn't include in this PR. |
Ah that is totally stale. Should be |
|
Turns out my shell alias for grepping repos was to restrictive and there are a bunch of mentions of Can you do a separate PR that fixes all those please? Then this one can go in on top of that, and then we can point release any crates that got changed. |
|
FWIW this changes is correct but means we have to do a major release not a point release. |
|
I did the |
I looked at this too when reviewing that PR, and I didn't understand how I missed them so I looked again. I think it's because there are 1622 occurrences of "node" on master, so we had to be more specific, and the "corepc-node" that need to be changed are not in "bitcoind/". Good catch though. |
Seems that bitcoind feature version name should have been 23_2 because that's what shows up in bitcoind.