add support for default-target#224
Closed
QuietMisdreavus wants to merge 2 commits intorust-lang:masterfrom
Closed
Conversation
QuietMisdreavus
changed the title
QuietMisdreavus
force-pushed
the
default-target
branch
from
b287f26 to
049c3e7
Compare
Contributor
Author
|
Closing in favor of #255, which has already merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes gives an effect to the
default-targetoption. A crate that adds adefault-targetto their docs.rs metadata in Cargo.toml will causedocs.rs/my_crate/$VERSION(anddocs.rs/my_crate) to redirect todocs.rs/my_crate/$VERSION/$DEFAULT_TARGET/my_crate(assuming a build target ofmy_crate).Caveat: the redirect doesn't check that the target has docs available. I'm not sure why but my local clone doesn't properly build and save docs for all targets, so accessingwhoops that was easier than i thought, all good now. I mean, the bug where it doesn't seem to get the docs for all the targets in a local clone still exists, but at least we don't get bogus redirects now.localhost:3000/winapiredirects properly tolocalhost:3000/winapi/0.3.5/x86_64-pc-windows-msvc/winapi/, but immediately hits a 404. This would work in docs.rs's production environment, but i want to look into adding a check, regardless.