Use default-target to build package#255
Merged
QuietMisdreavus merged 3 commits intorust-lang:masterfrom Nov 1, 2018
Merged
Conversation
QuietMisdreavus
approved these changes
Nov 1, 2018
Contributor
QuietMisdreavus
left a comment
There was a problem hiding this comment.
This looks good! As you mentioned, by doing the initial build on the default-target, this will ensure that crates that only build on that target (or are practically only available on a certain target even if they build everywhere, like winapi) are checked properly before giving up on building their documentation. I have one comment, but since it matches what the old code does, you can merge this without changing it.
Are you planning on rebuilding crates that already have a default-target set? The reason i went with a redirect for my version was because winapi was already published with that set, so it would work without having to rebuild it.
QuietMisdreavus
approved these changes
Nov 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my solution for default-target. It is using
default-targetmetadata option to build package in first place and placing default build to root of the crate documentation directory.For example winapi will always be build with
x86_64-pc-windows-msvctarget first and documentation crated with this target will be available indocs.rs/winapi/$version/winapi/.