Conversation
|
r? @gnzlbg (rust_highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Redox CI should be tested before merging, I know it compiles for Redox locally but I do not know if it will work on Travis.
This may require rust-lang/rust#60547
|
There appear to still be lots of errors even when using ctest 0.2.14. Do the tests pass for you locally? |
|
If the tests don't pass, you might want to add this CI job to the allowed_failures list for the moment, and once things are fixed upstream, try to get the test passing here. |
|
Triggering a new CI-build. This still had lots of CI errors last time. Would you mind fixing those? |
|
I think it's blocked on rust-lang/rust#60547 |
|
☔ The latest upstream changes (presumably c8aa8ec) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Can you also add this fix? |
|
It won't be necessary after rust-lang/rust#60547 |
|
Right now |
|
This needs rebasing. |
|
@jackpot51 any chance of getting back to this soon ? It would be great if you could run libc-test on redox, and update this to be "ABI compliant". |
|
Yes, I am very interested in that too. I'm just busy with trying to get rustc running on Redox |
|
I'm going to close this as inactive, feel free to re-open it or submit another PR when you find some time to work on (I've made some progress on #1934 so rebooting should be simple). |
This does the following: