Closed
Conversation
|
r? @gnzlbg (rust_highfive has picked a reviewer for you, use r? to override) |
jackpot51
approved these changes
Jul 5, 2019
Contributor
|
@bors: r+ |
Contributor
|
📌 Commit 1ca558d has been approved by |
Contributor
Contributor
|
💔 Test failed - checks-travis |
Contributor
|
@newpavlov please implement these like #1403 does. |
Contributor
|
@bors: r+ |
Contributor
|
📌 Commit 46cee95 has been approved by |
Contributor
Contributor
Author
|
Looks like some more involved fixes are needed. @jackpot51 can you handle |
Contributor
|
💔 Test failed - checks-travis |
Contributor
|
@newpavlov I would prefer if that happened in #1403 as well, could you send @jackpot51 a PR with your fix ? |
Closed
Contributor
Author
|
Done! Closing in favor of the linked PR. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1420